139 resonator class support 3d measurements#140
Open
Marius-Frohn wants to merge 49 commits intomasterfrom
Open
139 resonator class support 3d measurements#140Marius-Frohn wants to merge 49 commits intomasterfrom
Marius-Frohn wants to merge 49 commits intomasterfrom
Conversation
Collaborator
Author
|
Tested with full & partial 1D, 2D & 3D measurements |
Collaborator
Author
|
Using this branch for issue #138 aswell |
Collaborator
Author
|
Some minor refactoring overall: resonator fitting file management moved to spectroscopy since it used to exists specifically for the there implemented file structure and had to reconstruct the current state of the measurement depending on file state. New class can be dual used as custom circle fitter. legacy circlefit deleted for clean up log function file handling moved outside of spectroscopy/transport for a unified use since it is mostly independent of current measurement state |
…ze if desired, at cost of no convenient IQ-view and pre-calculated datasets
…circlefit depend on old mathematical implementation instead, untested
…s-support-3d-measurements
…: Fix previous measurement loggers not removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked Resonator Class to now only provide 1D freq, amp, phase in, 1D + 0D results out. Saving the output data is now handled by spectroscopy script itself with the necessary naming based on information gained from a fixed base class all fit functions are derived from.
Suppot for automatic circlefits in 3D measurements was added.
Old circlefit files (both classic and 2019) as well as old resonator class are kept as legacy in files but could theoretically be deleted