Skip to content

[WIP] Reconversion of Numeric Data to String and back to Numbers#12

Open
AbhinavChede wants to merge 1 commit intoqiyunlab:masterfrom
AbhinavChede:abhinav
Open

[WIP] Reconversion of Numeric Data to String and back to Numbers#12
AbhinavChede wants to merge 1 commit intoqiyunlab:masterfrom
AbhinavChede:abhinav

Conversation

@AbhinavChede
Copy link
Collaborator

I have made a few trivial edits in the rule.js file to fix the type reconversion of numeric data to String and back to Numbers. These changes allow us to pass in numeric data in Number format without having to convert the data into a String.

Copy link
Collaborator

@qiyunzhu qiyunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbhinavChede Thanks for the work! I had time to carefully go over the code. I think that an easier fix would be letting parseAssembly skip formatData and parseFieldType, and directly generate the final data. The two functions were designed to handle tables of variable formats. But an assembly file yields relatively fixed data formats. Therefore we perhaps don't need them.

Let me try to write a pull request to patch the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants