[WIP] Reconversion of Numeric Data to String and back to Numbers#12
Open
AbhinavChede wants to merge 1 commit intoqiyunlab:masterfrom
Open
[WIP] Reconversion of Numeric Data to String and back to Numbers#12AbhinavChede wants to merge 1 commit intoqiyunlab:masterfrom
AbhinavChede wants to merge 1 commit intoqiyunlab:masterfrom
Conversation
qiyunzhu
reviewed
Oct 31, 2021
Collaborator
qiyunzhu
left a comment
There was a problem hiding this comment.
@AbhinavChede Thanks for the work! I had time to carefully go over the code. I think that an easier fix would be letting parseAssembly skip formatData and parseFieldType, and directly generate the final data. The two functions were designed to handle tables of variable formats. But an assembly file yields relatively fixed data formats. Therefore we perhaps don't need them.
Let me try to write a pull request to patch the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made a few trivial edits in the rule.js file to fix the type reconversion of numeric data to String and back to Numbers. These changes allow us to pass in numeric data in Number format without having to convert the data into a String.