Pasqal local - Link munge optionally and inject a couple env variables into user env#172
Open
MatthieuMoreau0 wants to merge 1 commit intomainfrom
Open
Pasqal local - Link munge optionally and inject a couple env variables into user env#172MatthieuMoreau0 wants to merge 1 commit intomainfrom
MatthieuMoreau0 wants to merge 1 commit intomainfrom
Conversation
6c26770 to
6b3baa3
Compare
5 tasks
Collaborator
Author
|
This is finally ready for review alongside the QRMI MR. @ohtanim I am happy to get your feedback on this optional linking of munge. This is the first QRMI implementation which requires linking to a C library that is not required for the other implementations. You may have an opinion on how to handle this properly in terms of documentation and/or distribution. Thank you! |
ohtanim
reviewed
Mar 16, 2026
Collaborator
ohtanim
left a comment
There was a problem hiding this comment.
@MatthieuMoreau0 Thank you very much for your enhancement. Your changes look good to me, but I left 2 minor comments. Do you think my comments are reasonable to Pasqal ?
| /* | ||
| * This code is part of Qiskit. | ||
| * | ||
| * (C) Copyright IBM 2025 |
Collaborator
There was a problem hiding this comment.
Could you add Pasqal copyright?
| /* | ||
| * This code is part of Qiskit. | ||
| * | ||
| * (C) Copyright IBM 2025 |
Collaborator
There was a problem hiding this comment.
Could you please add Pasqal copyright ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
In this MR, I made a few updates to the spank plugin so that it supports the Pasqal Local QRMI introduced in qiskit-community/qrmi#32
Linking munge
For Pasqal Local we use munge to authenticate the root and end users, see QRMI MR for details on the auth flow. In this MR, I updated the CMakeLists.txt to link munge through the
-DENABLE_MUNGE=ONoption.When the option is activated, munge is dynamically linked:
Defining env variables for slurm job ID and UID
Each task submitted to the pasqal local middleware will be mapped to a slurm job ID and a UID. The UID enables us to isolate user data, the slurm job ID will help us map QPU tasks to a slurm job ID for debugging.
These can be retrived using
spank_get_itemand are mapped to env variables prefixed byQRMIas they are intended to be consumed by the QRMIChecklist ✅
Ticket