Add makefile targets to cover all steps found in the CI and INSTALL.md#87
Add makefile targets to cover all steps found in the CI and INSTALL.md#87cclaudio wants to merge 5 commits intoqiskit-community:mainfrom
Conversation
cclaudio
requested review from
OkuyanBoga,
awennersteen and
ohtanim
as code owners
|
The changes in this PR are ready for review. I converted it to draft just to prevent it from being merged as it includes the #84 patches (not squashed) |
Rename it to avoid confusion. We will also have PYTHON_VERSION. Signed-off-by: Claudio Carvalho <cclaudio@ibm.com>
No functional change. Later we will use it for shared variables and targets. Signed-off-by: Claudio Carvalho <cclaudio@ibm.com>
One of the best practices in Makefile is to avoid recursive $(MAKE) calls as they can break the dependency tracking, preventing the top-level make from seeing the full, global dependency picture. This patch moves the QRMI_VERSION to Makefile_common.mk to ensure it is always defined. This also wraps the Makefile_common.mk with ifndef to prevent it from being included multiple times. Signed-off-by: Claudio Carvalho <cclaudio@ibm.com>
No functional change. Just making sure the filename is consistent with tarball-vendor.yml. Signed-off-by: Claudio Carvalho <cclaudio@ibm.com>
Add all makefile targets needed to cover the steps found in the CI and in the INSTALL.md. With that, users can easily reproduce the same commands we use in the CI. The command below describes all targets available $ make help Fixes: qiskit-community#81 Signed-off-by: Claudio Carvalho <cclaudio@ibm.com>
|
#84 has been merged, thanks. |
| @@ -50,6 +50,7 @@ qrmi.h | |||
|
|
|||
| # python venvs | |||
| *venv | |||
There was a problem hiding this comment.
| *venv | |
| *venv* |
To cover both and more cases?
|
If there isnt (i guess there isnt) lets remember to add updating this file in #61 in a section targetted to making new backends? |
I am not sure I understand what is your concern, could you ellaborate? Indeed. The targets build-c-examples, clean-c-examples, fmt-pypkg, lint-pypkg, test-pypkg and create-venv have hardcoded paths. However, the idea is that the Makefile would become the single source of truth (or configuration) for those paths, supposedly we won't need to repeat them in other places like INSTALL.md or README.md files. In the future, if we need to consume those paths somewhere else other than the Makefile, we could create a |
3 participants
Fixes: #81
Depends-on: #84
The command below describes all targets implemented.
Once this PR is merged we can update the CI workflows and the INSTALL.md
Known issue
make test-docis failing. The rust doctests need to be fixed for them to pass.