Draft
Conversation
| .job_to_batch | ||
| .get(task_id) | ||
| .ok_or_else(|| anyhow!("No batch mapping found for Pasqal job id '{}'", task_id))?; | ||
| match self.api_client.cancel_batch(batch_id).await { |
Collaborator
There was a problem hiding this comment.
You can cancel the job instead of canceling the batch which will have the same effect. You won't need to store the batch_id in that case
| .job_to_batch | ||
| .get(task_id) | ||
| .ok_or_else(|| anyhow!("No Batch mapping found for Pasqal job id '{}'", task_id))?; | ||
| match self.api_client.get_batch_results(batch_id).await { |
Collaborator
There was a problem hiding this comment.
Unfortunately there is no endpoint in the cloud to get job results directly. You can get a s3 link using this route but for air-gapped nodes we prefer downloading the results server side.
I guess this can be refined later once we look into creating a batch in the acquire method as discussed in this #59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Checklist ✅
Ticket