[WIP] New ebi submit [WIP]

[adamrp]

Almost there, but I thought I'd get this in now so that people can begin reviewing, it's kind of big.

Needs:

• Logging
• Test code
• Script file (this is the library code)
• MD5 Calculations
• Final step that calls ASCP on the XML files generated

[wasade]

should this drop #?

[adamrp]

Yeah it could, but the prep/sample templates I get from Gail never have comment lines starting with #

[adamrp]

Thanks for the review @wasade, I'll implement these changes soon!

[ElDeveloper]

It would be nice to have descriptions for this and the subsequent Exceptions.

[ElDeveloper]

I like how the code is looking!

I would like to hear what your plans are for testing the main EBI object, as it stands right now, I can see that it's acting a lot as a data formatter, hence I would be inclined to leave the submission of files to a separate object, would be curious to hear what others think.

[wasade]

Agree, submit should be external
On Jun 9, 2014 1:21 PM, "Yoshiki Vázquez Baeza" notifications@github.com
wrote:

I like how the code is looking!

I would like to hear what your plans are for testing the main EBI object,
as it stands right now, I can see that it's acting a lot as a data
formatter, hence I would be inclined to leave the submission of files to a
separate object, would be curious to hear what others think.

—
Reply to this email directly or view it on GitHub
#704 (comment).

[wasade]

split_helper should be moved into here otherwise we have a circular dependency once the cmd line click'd interface imports EBISubmission