refactor: Changes runStorageT to run in Prerender #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that hydration works in reflex-dom, we should probably make runStorageT be more friendly to running the smallest possible prerender slices so that users can render as much of the DOM as they can that doesn't depend on the storage values. This change is a little bogus, because there is no way for the user to tell that they are getting nothing because switchover hasn't happened or because it actually isn't in local storage. I'm not sure whether this is a big deal or not, but it feels like it probably will cause an issue. We probably need to fix this, but I figured that I'd put this change in to start the conversation first and then test it out in realworld.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that hydration works in reflex-dom, we should probably make runStorageT be more friendly to running the smallest possible prerender slices so that users can render as much of the DOM as they can that doesn't depend on the storage values.
This change is a little bogus, because there is no way for the user to tell that they are getting nothing because switchover hasn't happened or because it actually isn't in local storage. I'm not sure whether this is a big deal or not, but it feels like it probably will cause an issue.
We probably need to fix this, but I figured that I'd put this change in to start the conversation first and then test it out in realworld.