updated dependencies #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endgame
reviewed
Jul 30, 2023
endgame
left a comment
endgame
left a comment
There was a problem hiding this comment.
Please don't remove the upper bounds; they're an important part of keeping build plans solvable, especially for older software (I recently had to make 25 revisions of http-conduit because they don't do upper bounds).
Once the bounds are right on this, I will make a metadata revision; this won't need a new release.
| , Reflex.Dom.Canvas.Context2D | ||
|
|
||
| build-depends: base >=4.9 && <=4.12 | ||
| build-depends: base |
There was a problem hiding this comment.
Please don't remove the upper bounds like this; you can use this wiki page to get the correct upper bound.
| , reflex >= 0.5 && <0.6 | ||
| , reflex-dom-core >= 0.4 && <0.5 | ||
| , reflex >= 0.4 && < 0.7 | ||
| , reflex-dom-core |
There was a problem hiding this comment.
Please add a correct upper bound here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fix for cabal file about updating imports.