Deprecate prometheus args #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
kamilsa
approved these changes
Jan 23, 2026
turuslan
approved these changes
Jan 23, 2026
Comment on lines
+898
to
+900
| if (find_argument(cli_values_map_, "metrics-host")) { | ||
| find_argument<std::string>( | ||
| cli_values_map_, "metrics-host", [&](const std::string &value) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (find_argument(cli_values_map_, "metrics-host")) { | |
| find_argument<std::string>( | |
| cli_values_map_, "metrics-host", [&](const std::string &value) { | |
| if (auto &&value = find_argument<std::string>(cli_values_map_, "metrics-host")) { |
Contributor
There was a problem hiding this comment.
template <typename T>
std::optional<T> find_argument_deprecated(boost::program_options::variables_map &vm,
const std::string &name, const std::string &name, const std::string &deprecated_name) { ... }
auto arg_metrics_host = find_argument_deprecated(cli_values_map_, "metrics-host", "prometheus-host");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metrics-* CLI args.
Deprecate prometheus-* CLI args.
Resolves #36