leanMultisig aggregation #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilsa
requested review from
kamilsa and
xDimon
and removed request for
kamilsa
kamilsa
approved these changes
Jan 20, 2026
kamilsa
reviewed
Jan 20, 2026
xDimon
reviewed
Jan 20, 2026
| } | ||
| if (not justifications_it->second.at(validator_id)) { | ||
| justifications_it->second.at(validator_id) = true; | ||
| for (auto &&validator_id : |
Member
There was a problem hiding this comment.
Why validator_id is rvalue? It doesn't make sense here, do nothing, but confuses a bit.
Contributor
Author
There was a problem hiding this comment.
auto && is not rvalue, it means that deduced auto may accept both value and reference.
auto c = ref; // copy constructor
auto &c = ref; // reference
auto c = 1; // int c
auto &c = 1; // error
const auto &c = 1; // const int &c
auto &&c = ref; // reference
auto &&c = 1; // int c
Member
There was a problem hiding this comment.
Yes, and it makes sense in templates only. In this case, the type will be inferred unambiguously from the return value of the function getAggregatedValidators.
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
xDimon
approved these changes
Jan 23, 2026
| } | ||
| if (not justifications_it->second.at(validator_id)) { | ||
| justifications_it->second.at(validator_id) = true; | ||
| for (auto &&validator_id : |
Member
There was a problem hiding this comment.
Yes, and it makes sense in templates only. In this case, the type will be inferred unambiguously from the return value of the function getAggregatedValidators.
xDimon
reviewed
Jan 23, 2026
Signed-off-by: turuslan <turuslan.devbox@gmail.com> # Conflicts: # src/blockchain/fork_choice.cpp
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.