refactor(date-utils) ♻️ Rename misleading getDayOfWeekCode to getDayOfMonthCode #73
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balajis-qb
force-pushed
the
refactor/date-utils
branch
2 times, most recently
from
321d5d7 to
26c4384
Compare
- Function name updated to reflect day-of-month behaviour - Removed the unused locale argument - Documentation updated to describe ddd formatting - No functional changes
balajis-qb
force-pushed
the
refactor/date-utils
branch
from
26c4384 to
56574ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: Hacker0x01#6217
Problem
This PR renames a date utility function and update its documentation to correctly reflect it's day-of-month behaviour when using the ddd format. The previous name
getDayOfWeekCodeimplies it would return week codes like 'sun', 'mon', etc. However, it actually returns the day of the month as a zero-padded 3-digit string (e.g. "001", "002", "003", etc).Changes
getDayOfWeekCodetogetDayOfMonthCodeContribution checklist