Fix #13722: FileUpload click instead of mouseup #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoyDiego
approved these changes
Sep 24, 2023
SoyDiego
left a comment
SoyDiego
left a comment
There was a problem hiding this comment.
I tested and works perfectly but maybe for any reason the developers of PrimeNG are doing that @cetincakiroglu.
You are right @balajis-qb, also if you click with the mousewheel is opening the window to select a file too.
Collaborator
Author
|
Hi @SoyDiego , Thank you for approving my PR. Actually this PR is pointing to my forked repo's master. The correct PR I made was primefaces#13723 Sorry for the inconvenience. Could you please review my PR from this link (primefaces#13723)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a summary of the changes made
Please review the code changes, and if everything looks good, consider merging this update.