Fix workflow run detection to prevent concurrent executions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses critical issues where Turnstyle wasn't properly waiting for previous workflow runs to complete, potentially causing concurrent deployments. **Issues Fixed:** 1. **Missing workflow run states** (github.ts) - Added queries for `pending`, `requested`, and `action_required` states - Previously only queried `in_progress`, `queued`, and `waiting` - Missing states caused Turnstyle to skip active runs 2. **Incorrect filtering logic** (wait.ts) - Changed from only skipping successful runs to skipping all completed runs - Now only waits for active runs (those without a conclusion) - Previously waited unnecessarily for failed/cancelled runs 3. **Test coverage** (wait.test.ts) - Updated test to verify all 6 active states are handled - Added test for skipping failed/cancelled runs **Impact:** - Prevents concurrent workflow executions in high-frequency trigger scenarios - Properly handles workflows with approval steps (pending/action_required states) - No longer blocks on failed/cancelled runs Refs: https://docs.github.com/en/rest/actions/workflow-runs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The test "will skip failed and cancelled runs" now expects 4 debug messages instead of 2 because the wait() method is called twice in the test scenario: - First iteration: filters out runs 1 & 2 (2 messages) - Second iteration: filters out runs 1 & 2 again (2 more messages) This reflects the actual behavior where completed runs are logged each time they are filtered during the wait loop. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolved conflicts by combining: - New workflow run states (pending, requested, action_required) from fix/workflow-run-states - Console.log debugging statements from master - Maintained both console.log for visibility and this.debug for test assertions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vibaiher-qatium
force-pushed
the
fix/workflow-run-states
branch
from
f89f18a to
f76e6b0
Compare
Author
|
Let's wait for the debugging feature to see if this PR makes sense or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical issues where Turnstyle wasn't properly waiting for previous workflow runs to complete, potentially causing concurrent deployments.
🔴 Issues Fixed
1. Missing Workflow Run States (src/github.ts)
in_progress,queued,waiting)pending,requested,action_required2. Incorrect Filtering Logic (src/wait.ts)
conclusion === 'success'3. Enhanced Test Coverage (tests/wait.test.ts)
📊 Impact Assessment
🧪 Testing
📝 Changes
src/github.ts: Added API queries for
pending,requested, andaction_requiredstatessrc/wait.ts: Changed filtering logic to only wait for active runs (no conclusion)
tests/wait.test.ts: Enhanced test coverage for new states and filtering behavior
dist/index.js: Rebuilt distribution bundle with changes
🔗 References
🤖 Generated with Claude Code