Skip to content

Fix CI type-check failures and lint errors#2

Merged
qCanoe merged 1 commit intoclaude/plan-project-roadmap-bBAWIfrom
codex/fix-mypy-type-errors
Mar 16, 2026
Merged

Fix CI type-check failures and lint errors#2
qCanoe merged 1 commit intoclaude/plan-project-roadmap-bBAWIfrom
codex/fix-mypy-type-errors

Conversation

@qCanoe
Copy link
Copy Markdown
Owner

@qCanoe qCanoe commented Mar 16, 2026

Motivation

  • CI was failing with mypy errors about Any return values from RPC helpers and several lint/import issues reported by ruff.
  • The extractor had type/variable mixups between asset and permission changes which caused type-check failures and unused-variable lints.

Description

  • Validate RPC client return payloads in Simulator before returning to satisfy mypy (check for None and dict in get_transaction, get_transaction_receipt, and _get_trace).
  • Separate asset vs permission variables in DeltaExtractor event loop and rename to permission_change where appropriate to avoid type confusion.
  • Move contract_addr and data extraction into each parser and add explicit changes: List[AssetChange] typing for ERC1155 batch handling.
  • Run ruff --fix and apply small manual cleanups to remove unused imports and redefinitions across modules and tests (including removing unused ETH_ADDRESS import in tests/test_types.py).

Testing

  • Ran static type checks with mypy src/ --ignore-missing-imports and it completed with no issues.
  • Ran linter checks with ruff check . and all checks passed.
  • Ran the test suite with pytest -q and all tests passed (57 passed).

Codex Task

@qCanoe qCanoe merged commit a308148 into claude/plan-project-roadmap-bBAWI Mar 16, 2026
6 checks passed
@qCanoe qCanoe deleted the codex/fix-mypy-type-errors branch March 16, 2026 14:00
@qCanoe qCanoe restored the codex/fix-mypy-type-errors branch March 16, 2026 14:06
@qCanoe qCanoe deleted the codex/fix-mypy-type-errors branch March 16, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant