Fix CI type-check failures and lint errors#2
Merged
qCanoe merged 1 commit intoclaude/plan-project-roadmap-bBAWIfrom Mar 16, 2026
Merged
Fix CI type-check failures and lint errors#2qCanoe merged 1 commit intoclaude/plan-project-roadmap-bBAWIfrom
qCanoe merged 1 commit intoclaude/plan-project-roadmap-bBAWIfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mypyerrors aboutAnyreturn values from RPC helpers and several lint/import issues reported byruff.Description
Simulatorbefore returning to satisfymypy(check forNoneanddictinget_transaction,get_transaction_receipt, and_get_trace).DeltaExtractorevent loop and rename topermission_changewhere appropriate to avoid type confusion.contract_addranddataextraction into each parser and add explicitchanges: List[AssetChange]typing for ERC1155 batch handling.ruff --fixand apply small manual cleanups to remove unused imports and redefinitions across modules and tests (including removing unusedETH_ADDRESSimport intests/test_types.py).Testing
mypy src/ --ignore-missing-importsand it completed with no issues.ruff check .and all checks passed.pytest -qand all tests passed (57 passed).Codex Task