Close websocket connection before asyncio.run() terminates#315
Open
yubiuser wants to merge 1 commit intopytr-org:masterfrom
Open
Close websocket connection before asyncio.run() terminates#315yubiuser wants to merge 1 commit intopytr-org:masterfrom
yubiuser wants to merge 1 commit intopytr-org:masterfrom
Conversation
Signed-off-by: yubiuser <github@yubiuser.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that the websocket connection is not properly closed before asyncio.run() terminates. This resulted in the following error
This PR added async def close() method to TradeRepublicApi in api.py that gracefully closes the websocket. The new method is now used at the end of each async loop.
Now it shuts down without error.