Skip to content

Retry for torch_multimodal_clip download #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atalman wants to merge 4 commits into from
Closed

Retry for torch_multimodal_clip download #2661

atalman wants to merge 4 commits into from

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Dec 30, 2025 •
edited
Loading

Test:

python install.py
Rate limited (429). Retrying in 3 seconds... (attempt 1/10)
Rate limited (429). Retrying in 6 seconds... (attempt 2/10)
Rate limited (429). Retrying in 12 seconds... (attempt 3/10)
Rate limited (429). Retrying in 24 seconds... (attempt 4/10)
Successfully downloaded /data/users/atalman/benchmark/torchbenchmark/models/torch_multimodal_clip/.data/pizza.jpg
  1. More realistic headers
  2. Retries when trying to download the image

@meta-cla meta-cla bot added the cla signed label Dec 30, 2025
huydhn
huydhn approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to bump torchbench pin to get this change https://github.com/pytorch/pytorch/blob/main/.ci/docker/ci_commit_pins/torchbench.txt on PyTorch side

@meta-codesync
Copy link

meta-codesync bot commented Dec 30, 2025

@atalman has imported this pull request. If you are a Meta employee, you can view this in D89906869.

@atalman atalman mentioned this pull request Dec 30, 2025
Closed
@atalman atalman temporarily deployed to docker-s3-upload December 30, 2025 00:41 — with GitHub Actions Inactive
@atalman atalman temporarily deployed to docker-s3-upload December 30, 2025 00:41 — with GitHub Actions Inactive
@meta-codesync meta-codesync bot closed this in 9c2cc75 Dec 30, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 30, 2025

@atalman merged this pull request in 9c2cc75.

pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Dec 30, 2025
@atalman @pytorchmergebot
Bump torchbench version (#171490)
a810249 
To include pytorch/benchmark#2661

Pull Request resolved: #171490
Approved by: https://github.com/huydhn, https://github.com/oulgen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@oulgen oulgen oulgen approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @huydhn @oulgen @facebook-github-bot