Skip to content

Move CI to "ubuntu-latest" (round 2) #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 12 commits into from
Apr 2, 2025
Merged

Move CI to "ubuntu-latest" (round 2) #570

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
616c0f4
Move CI to "ubuntu-latest"
JelleZijlstra Apr 1, 2025
29bde2d
try
JelleZijlstra Apr 1, 2025
ae6f37a
this way?
JelleZijlstra Apr 1, 2025
2fc53d3
Do not depend on test.support
JelleZijlstra Apr 1, 2025
58b4ab2
Don't need cache
JelleZijlstra Apr 1, 2025
f91313c
try 22.04
JelleZijlstra Apr 1, 2025
da686cb
Bump 3.{8,9,10}.0 to earliest versions supported by 22.04 runner
brianschubert Apr 2, 2025
524a5c2
Use 22.04 runner for SQLAlchemy tests
brianschubert Apr 2, 2025
67205cb
Use ubuntu-latest
brianschubert Apr 2, 2025
bb7c7dd
Drop 3.8
brianschubert Apr 2, 2025
3103934
Leave test.support dependency for now
brianschubert Apr 2, 2025
2e72d44
Re-add 3.8
brianschubert Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,10 @@ jobs:
# https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
python-version:
- "3.8"
Copy link
Member

@JelleZijlstra JelleZijlstra Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep 3.8 (not 3.8.0) for now, we still want to test 3.8 for the upcoming bugfix release, and it seems to work on 22.04.

Copy link
Contributor Author

@brianschubert brianschubert Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good - do we want to also include any earlier version that 22.04 supports?

Copy link
Member

@JelleZijlstra JelleZijlstra Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels not worth it, the testing on point releases is a bit of a spotcheck anyway. Thanks!

- "3.8.0"
- "3.9"
- "3.9.0"
- "3.9.12"
- "3.10"
- "3.10.0"
- "3.10.4"
- "3.11"
- "3.11.0"
- "3.12"
Expand All @@ -54,7 +53,7 @@ jobs:
- "pypy3.9"
- "pypy3.10"

runs-on: ubuntu-20.04
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
Expand All @@ -70,6 +69,7 @@ jobs:
# Be wary of running `pip install` here, since it becomes easy for us to
# accidentally pick up typing_extensions as installed by a dependency
cd src
python --version # just to make sure we're running the right one
python -m unittest test_typing_extensions.py

- name: Test CPython typing test suite
Expand Down
Loading