gh-66802: Add unicodedata.block() function#145042
Open
StanFromIreland wants to merge 5 commits intopython:mainfrom
Open
gh-66802: Add unicodedata.block() function#145042StanFromIreland wants to merge 5 commits intopython:mainfrom
unicodedata.block() function#145042StanFromIreland wants to merge 5 commits intopython:mainfrom
Conversation
StanFromIreland
requested review from
ezio-melotti,
malemburg and
serhiy-storchaka
| [clinic start generated code]*/ | ||
|
|
||
| static PyObject * | ||
| unicodedata_block_impl(PyObject *module, int chr) |
Member
There was a problem hiding this comment.
Have you tried other approaches for this, and compared the performances?
Member
Author
There was a problem hiding this comment.
| Table with ranges & bin search (PR) | Adding to each record | |
|---|---|---|
| unique properties | 395 | 1829 |
size of unicodedata_db.h (bytes) |
626,364 | 759,474 |
| simple bench* | 498 nsec per loop | 490 nsec per loop |
* ./python -m timeit -v -r 10 -n 1000000 -s "import unicodedata; b=unicodedata.block" "b('\u0041');b('\u4E00');b('\U0010FFFF')"
The lookup difference is minor, and we save quite a bit of memory (~17%), so I think this approach is better.
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
vstinner
reviewed
Feb 21, 2026
vstinner
approved these changes
Feb 21, 2026
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. The implementation with a binary tree is efficient (CPU, memory). It's a reasonable addition to the unicodedata module.
malemburg
approved these changes
Feb 21, 2026
Member
malemburg
left a comment
malemburg
left a comment
There was a problem hiding this comment.
LGTM, but please do check whether using size_t for namelen wouldn't be better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--145042.org.readthedocs.build/