gh-143474: Add os.RWF_ATOMIC constant#143475
Conversation
|
All commit authors signed the Contributor License Agreement. |
claydugo
force-pushed
the
gh-143474-rwf-atomic
branch
from
05b03ad to
90be11b
Compare
| - RWF_SYNC | ||
| - RWF_APPEND | ||
| - RWF_DONTCACHE | ||
| - RWF_ATOMIC |
There was a problem hiding this comment.
(i work with clay and he has been keeping me updated on the discussion thx all)
May I suggest we follow the order from
https://github.com/torvalds/linux/blob/7f98ab9da046865d57c102fd3ca9669a29845f67/include/uapi/linux/fs.h#L429
these low level flags are pretty tricky to get right, and to validate, keeping the order the "same" helps triple check things.
Excited that this is getting a revival!
There was a problem hiding this comment.
We can consider that for a follow-up PR. I think it's important to keep the blame intact here, so when Linux goes and adds new flags, we can quickly look up the precedent for adding them.
|
I'm going to merge this. It's intentional that this doesn't have a "What's New" entry, since one wasn't added for |
|
Very cool. Thanks! |
3 participants
os.RWF_ATOMICconstant #143474📚 Documentation preview 📚: https://cpython-previews--143475.org.readthedocs.build/