gh-93417: Update mimetypes.init() doc to match the code#141393
Open
bebound wants to merge 1 commit intopython:mainfrom
Open
gh-93417: Update mimetypes.init() doc to match the code#141393bebound wants to merge 1 commit intopython:mainfrom
mimetypes.init() doc to match the code#141393bebound wants to merge 1 commit intopython:mainfrom
Conversation
mimetypes.init() doc to match the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a supplement of #3062. Change the doc to match the current behavior.
After #3062, the
init(files)function still loads theknownfileswhenfiles=[]:cpython/Lib/mimetypes.py
Lines 405 to 433 in 9b0179f
The above doc reflects on the old code logic:
cpython/Lib/mimetypes.py
Lines 341 to 358 in 27a8564
PS: I did not walk through the https://bugs.python.org/issue4963 to see whether the
init(files=[])behavior change is necessary. (Well, reverting to Python 3.7's behavior is also unlikely?) For now, we should at least update the documentation.📚 Documentation preview 📚: https://cpython-previews--141393.org.readthedocs.build/