Update path to WASI config.site in Wasm32WasiCrossBuild factory#601
Merged
zware merged 4 commits intopython:mainfrom Jun 4, 2025
Merged
Update path to WASI config.site in Wasm32WasiCrossBuild factory#601zware merged 4 commits intopython:mainfrom
Wasm32WasiCrossBuild factory#601zware merged 4 commits intopython:mainfrom
Conversation
Member
Author
|
Aha, this builder is meant for branches that may have the old location so something more clever is needed. Perhaps a step before configure is run could find the file? |
brettcannon
reviewed
Jun 4, 2025
brettcannon
approved these changes
Jun 4, 2025
zware
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config.site used for WASI cross builds that don't use
wasi.pymoved last month, and now lives at Tools/wasm/wasi/config.site-wasm32-wasi. The path hasn't been updated in the builder though, so the config.site is not getting picked up for the cross builds.Example failure: https://buildbot.python.org/#/builders/1373/builds/515