feat: enforce file newlines with super-linter and pre-commit hooks #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I will rebase this when #885 merges and apply any additional fixes. |
Add EditorConfig configuration to ensure all files end with a single newline character and trim trailing whitespace. Enable VALIDATE_EDITORCONFIG in super-linter workflow to enforce these rules in CI. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add pre-commit configuration with hooks to: - Ensure all files end with single newline (end-of-file-fixer) - Remove trailing whitespace (trailing-whitespace) - Validate YAML and TOML syntax - Prevent merge conflict markers Integrate with existing hatch workflow and add CI job. Include setup instructions in CLAUDE.md. Applied automatic formatting fixes to existing files. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
dhellmann
force-pushed
the
linter-newlines
branch
from
5f838d6 to
3a4952b
Compare
LalatenduMohanty
requested changes
Dec 17, 2025
.github/workflows/check.yaml
Outdated
| run: python -m pip install hatch 'click!=8.3.0' | ||
|
|
||
| - name: Run pre-commit hooks | ||
| run: hatch run lint:install-hooks && hatch run lint:check |
Member
There was a problem hiding this comment.
I think you meant run: hatch run lint:precommit instead of hatch run lint:check
Member
Author
There was a problem hiding this comment.
Good catch, yes. I've fixed that.
Add local hooks to run hatch lint:check and mypy:check as part of pre-commit workflow, ensuring comprehensive code quality checks before commits. Add separate 'precommit' hatch script to manually run pre-commit hooks without circular dependency. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove the old pre-commit script and rely instead on the pre-commit command to run the linters. Update the documentation to reflect the change in how the hook should be configured.
Add explicit utf-8 charset to fix super-linter EditorConfig validation error complaining about "Ascii" instead of "" encoding. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
dhellmann
force-pushed
the
linter-newlines
branch
from
2b6d13b to
d7437f3
Compare
| @@ -0,0 +1,26 @@ | |||
| repos: | |||
| - repo: https://github.com/pre-commit/pre-commit-hooks | |||
| rev: v4.5.0 | |||
Member
There was a problem hiding this comment.
The recent version is v6.0 , I guess the bot will update it once we merge this PR?
Member
Author
There was a problem hiding this comment.
Yeah, the agent wrote this so I expect it was just using an older version. Let's see what dependabot gives us.
LalatenduMohanty
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Developer Commands
Pre-commit now automatically runs on every commit with comprehensive file formatting, linting, and type checking.
🤖 Generated with https://claude.ai/code