fix(build): correct skipped status in build-sequence-summary.json #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect logic that marked all non-prebuilt wheels as skipped when using --cache-wheel-server-url. The bug was in the _build() function where an else clause unconditionally set use_exiting_wheel=True for all non-prebuilt packages, regardless of whether they were actually built or reused. Changes: - Only set use_exiting_wheel=True when we actually have an existing wheel - Consolidate duplicate prebuilt wheel checks into single block - Eliminate redundant wheel_filename validation - Add test validation for build-sequence-summary.json content The fix ensures packages built from source show skipped=false and packages using existing wheels show skipped=true in the summary file. Closes: #777 Chat log: https://gist.github.com/dhellmann/55da9cedbc977fe644f2c7584c7d1762 Co-authored-by: Claude 3.5 Sonnet (Anthropic AI Assistant) Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
tiran
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect logic that marked all non-prebuilt wheels as skipped when using --cache-wheel-server-url. The bug was in the _build() function where an else clause unconditionally set use_exiting_wheel=True for all non-prebuilt packages, regardless of whether they were actually built or reused.
Changes:
The fix ensures packages built from source show skipped=false and packages using existing wheels show skipped=true in the summary file.
Closes: #777
Chat log: https://gist.github.com/dhellmann/55da9cedbc977fe644f2c7584c7d1762
Co-authored-by: Claude 3.5 Sonnet (Anthropic AI Assistant)