Detect if we have already seen the dependency before downloading sources #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2024 16:11
… downloading the source Signed-off-by: Shubh Bapna <sbapna@redhat.com>
Signed-off-by: Shubh Bapna <sbapna@redhat.com>
shubhbapna
force-pushed
the
resolve-then-detect-duplicate
branch
from
53208a4 to
daba74a
Compare
dhellmann
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #510
Resolving and then immediately detecting if we have seen the dependency allows us to avoid paying the cost of trying to download and verify the sdist tarball each time that dependency is requested.
On our downstream systems just torch itself was spending 3 minutes total in
download_sourcein a single bootstrap run with all performance features enabled. This brings it down to 5 seconds for torch (didn't measure it for other dependencies)