use zipfile library instead of wheel command to unpack a wheel #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhbapna
force-pushed
the
use-zipfile
branch
2 times, most recently
from
07a0202 to
5dda615
Compare
Contributor
Author
|
This change results in a 10% performance bump in our downstream builds compared to the main branch |
Signed-off-by: Shubh Bapna <sbapna@redhat.com>
shubhbapna
force-pushed
the
use-zipfile
branch
from
5dda615 to
67e414b
Compare
dhellmann
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #507
We save at the very least the cost of spawning a new process to unpack the wheel for each dependency