Fix py312+ crash test skips to correctly check for assertions #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the skips for `test_trace_events_multiple_greenlets_switching*` to correctly detect assertions being enabled independently of `--with-pydebug`. Gentoo builds Python `--without-pydebug` but `--with-assertions`, in order to benefit from assertion-implied safety checks without the full cost of PyDEBUG. For the purpose of detecting it, check for `-DNDEBUG` in optimization flags, as implied by disabling assertions. Leave the existing code as a fallback for when build flags are unavailable, e.g. in Windows packages. Signed-off-by: Michał Górny <mgorny@gentoo.org>
mgorny
force-pushed
the
fix-assert-test-skips
branch
from
f16e3c0 to
739cc55
Compare
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 31, 2025
Use an upstreamable patch to avoid crashes on py3.12+ instead of sed. This has the clear advantage of not skipping the test on older Python versions. Pull-Request: python-greenlet/greenlet#457 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Contributor
|
Thanks! |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the skips for
test_trace_events_multiple_greenlets_switching*to correctly detect assertions being enabled independently of--with-pydebug. Gentoo builds Python--without-pydebugbut--with-assertions, in order to benefit from assertion-implied safety checks without the full cost of PyDEBUG. For the purpose of detecting it, check for-DNDEBUGin optimization flags, as implied by disabling assertions. Leave the existing code as a fallback for when build flags are unavailable, e.g. in Windows packages.