ruff check --select=E --fix --unsafe-fixes#103
Closed
cclauss wants to merge 1 commit intopython-cffi:mainfrom
Closed
ruff check --select=E --fix --unsafe-fixes#103cclauss wants to merge 1 commit intopython-cffi:mainfrom
cclauss wants to merge 1 commit intopython-cffi:mainfrom
Conversation
Contributor
|
I know I didn't follow the letter of PEP 8 when writing CFFI. It's far too late now. I'm not reviewing changes to 42 files just for stylistic purposes, sorry. Additionally, CFFI is mostly in maintenance mode only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's consider this after #102 is merged so we can ensure that the pytests continue to pass with these changes.
Which ruff rules E can be automatically fixed?
%
ruff check --statistics | grep "\[\*\]"%
ruff check --select=E --fix --unsafe-fixes%
ruff rule E731# https://docs.astral.sh/ruff/rules/lambda-assignmentlambda-assignment (E731)
Derived from the pycodestyle linter.
Fix is sometimes available.
What it does
Checks for lambda expressions which are assigned to a variable.
Why is this bad?
Per PEP 8, you should "Always use a def statement instead of an assignment
statement that binds a lambda expression directly to an identifier."
Using a
defstatement leads to better tracebacks, and the assignmentitself negates the primary benefit of using a
lambdaexpression (i.e.,that it can be embedded inside another expression).
Example
Use instead: