Ensure newline before new section when file lacks trailing newline#142
Open
bysiber wants to merge 1 commit intopyscaffold:mainfrom
Open
Ensure newline before new section when file lacks trailing newline#142bysiber wants to merge 1 commit intopyscaffold:mainfrom
bysiber wants to merge 1 commit intopyscaffold:mainfrom
Conversation
When a config file doesn't end with a newline character, add_section() would append the new section header directly after the last value, producing malformed output like "option2 = value2[section2]". Insert a newline Space block before the new section when the last existing block doesn't end with one. Fixes pyscaffold#126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126.
When a config file doesn't end with a newline,
add_section()appends the section header directly after the last value, producing malformed output likeoption2 = value2[section2].The fix inserts a newline before the new section when the last existing block in the document doesn't end with one. Files that already have a trailing newline are unaffected.