Add a notebook to explore sub-networks#74
Add a notebook to explore sub-networks#74ekatef wants to merge 1 commit intopypsa-meets-earth:mainfrom
Conversation
d4a3ed3 to
945b3a7
Compare
945b3a7 to
f232747
Compare
|
@davide-f would you have time to review it? The idea is to have a simple tool which can be used to check topology of the resulted grid model. |
davide-f
left a comment
There was a problem hiding this comment.
Very nice! @ekatef :D
And quite useful for the PRs on the isolated network ones :)
The general perspective is that they are clear and the code is ok as is in my opinion, I would only add some text to describe what is being done.
I was wondering if rather than creating a new notebook, we may revise an existing one.
For example, base_network seemed a good candidate, what is your opinion?
Thanks a lot for reviewing @davide-f! Agree by all the points :) Would you mind to keep this PR open in meantime? The scripts are pretty useful for quick investigation of the network topology, and sometimes I'm using this PR to quickly share the approach. (I'll do my best to avoid making this meantime getting too long!) |
|
No problem :) we can definitely keep it open! |
A simple notebook which may be useful to explore topology of isolated sub-networks.