Ignore newlines when processing keywords/platforms#4888
Draft
frenzymadness wants to merge 1 commit intopypa:mainfrom
Draft
Ignore newlines when processing keywords/platforms#4888frenzymadness wants to merge 1 commit intopypa:mainfrom
frenzymadness wants to merge 1 commit intopypa:mainfrom
Conversation
Newlines in `keywords` or `platforms` can break the produced metadata in PKG-INFO or METADATA files. Fixes: pypa#4887
Contributor
|
Thank you very much @frenzymadness for having a look on this issue and proposing a solution. I think we have 2 options according to https://setuptools.pypa.io/en/latest/development/developer-guide.html#code-conventions-and-other-practices (see description about modifying files in the
In the case we go for a change in the |
Contributor
Author
|
You are right, sorry. Let me take this to distutils and see what they think about this change there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Newlines in
keywordsorplatformscan breakthe produced metadata in PKG-INFO or METADATA files.
Fixes: #4887
Pull Request Checklist
newsfragments/].