Tests: Stop requiring wheel.whl in common_wheels#13382
Tests: Stop requiring wheel.whl in common_wheels#13382
Conversation
|
We'd need #13358 to be merged to remove our dependency on wheel in the test suite AFAICT. #13330 only changes pip to only require setuptools to be installed for |
|
Thanks for the hint. Considering #13358 is closed, should I close this as well? |
|
Yeah, given that it's only recently that setuptools no longer requires wheel, it's likely too risky to drop the requirement. How bad is it to depend on wheel for y'all at Fedora? |
The new version that has runtime dependencies was yanked. But once it has runtime dependencies, building our own wheel of it no longer makes sense, so I was considering dropping it for good. We can probably use an older version of wheel here for the time being, don't worry about that. What makes me wonder is: Is wheel now installed in the tests just so it can be checked if it's installed? aka if the wheel was "dummy" and contained no code, it would still work? |
Maybe? I'd need to research. In any case we are going to remove all that in 25.3. So in the meantime I think we should not touch the setup.py develop and bdist_wheel code paths at all, to not create additional churn/risks/confusion. I'm (slowly) working to make the test suite PEP 517 only. If it's ready before 25.2 we can also decide to stop testing the legacy code paths before 25.3, so downstream redistributors can run tests in pure PEP 517 only mode. But we'll see how quickly I progress. |
In Fedora, we are using a packaged wheel.whl to run the tests (well, at least that was the idea), but considering wheel now has runtime dependencies, we are trying to get rid of it. I thought this would be an easy way to not require it here, after #13330 -- but clearly I am missing something.
This is a proof of concept, it doesn't work, some tests fail with:
And I am not entirely sure why yet.