Open
Conversation
sbidoul
force-pushed
the
direct_url-sbi
branch
from
a41e6c1 to
c056624
Compare
Member
|
I'm fine with the approach. Not sure if there's anything to borrow/share with @pradyunsg @henryiii @notatallshaw any opinions? |
sbidoul
force-pushed
the
direct_url-sbi
branch
3 times, most recently
from
941c15c to
c6e7e4a
Compare
sbidoul
force-pushed
the
direct_url-sbi
branch
from
c5e540e to
d16bb8d
Compare
sbidoul
force-pushed
the
direct_url-sbi
branch
from
d16bb8d to
1ad3f90
Compare
sbidoul
force-pushed
the
direct_url-sbi
branch
2 times, most recently
from
bcb9c3a to
ca29d5e
Compare
sbidoul
force-pushed
the
direct_url-sbi
branch
from
ca29d5e to
74d09a2
Compare
Member
Author
I don't think so. The concepts are close, but the data structures are different. This is now complete and ready for review. |
henryiii
reviewed
Feb 23, 2026
henryiii
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this to show what
direct_url.jsonsupport could look like, in the same style as what I did for pylock in #900.If maintainers agree with the approach, I'll be happy to move this forward.
Towards #701.