pylock: add filename property to PackageSdist and PackageWheel, more validation#1095
Open
pylock: add filename property to PackageSdist and PackageWheel, more validation#1095
Conversation
sbidoul
commented
Feb 21, 2026
sbidoul
commented
Feb 21, 2026
sbidoul
commented
Feb 21, 2026
sbidoul
commented
Feb 21, 2026
| elif "\\" in path: | ||
| return path.rsplit("\\", 1)[-1] | ||
| else: | ||
| return path |
Member
Author
There was a problem hiding this comment.
Here this is an heuristic to determine the name from the path, as the spec does not enforce path separators.
sbidoul
commented
Feb 21, 2026
Member
Author
|
@brettcannon a few questions for you on the interpretation of PEP 751. |
sbidoul
commented
Feb 21, 2026
| return package_wheel | ||
|
|
||
| @property | ||
| def filename(self) -> str: |
Member
Author
There was a problem hiding this comment.
I consider renaming this property to wheel_name. See also #1092 (comment).
- add filename property to PackageSdist and PackageWheel - validate sdist and wheel filenames
sbidoul
force-pushed
the
pylock-validate-wheel
branch
from
58728a0 to
27cbf4a
Compare
Member
I think I answered everything, but in case I didn't just let me know! |
Member
Author
|
Thanks Brett. So this is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To implement
Pylock.selectwe need a way to determine the filename of aPackageWheelfrom itsnameorurlorpath.So here I add a
filenameproperty toPackageWheelandPackageSdist.I also add validation of these names in
from_dict.