Skip to content

Fix incorrect self-comparison for InfinityType and NegativeInfinityType #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bysiber wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −6
Open

Fix incorrect self-comparison for InfinityType and NegativeInfinityType #1093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ceef64
Fix incorrect self-comparison for InfinityType and NegativeInfinityType
bysiber Feb 20, 2026
0b2c301
Add self-comparison tests for Infinity types
bysiber Feb 20, 2026
b090b04
Use identity checks instead of isinstance for singleton comparison
bysiber Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/packaging/_structures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ def __lt__(self, other: object) -> bool:
return False

def __le__(self, other: object) -> bool:
return False
return other is self

def __eq__(self, other: object) -> bool:
return isinstance(other, self.__class__)
return other is self

def __gt__(self, other: object) -> bool:
return True
return other is not self

def __ge__(self, other: object) -> bool:
return True
Expand All @@ -48,19 +48,19 @@ def __hash__(self) -> int:
return hash(repr(self))

def __lt__(self, other: object) -> bool:
return True
return other is not self

def __le__(self, other: object) -> bool:
return True

def __eq__(self, other: object) -> bool:
return isinstance(other, self.__class__)
return other is self

def __gt__(self, other: object) -> bool:
return False

def __ge__(self, other: object) -> bool:
return False
return other is self

def __neg__(self: object) -> InfinityType:
return Infinity
Expand Down
14 changes: 14 additions & 0 deletions tests/test_structures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,24 @@ def test_infinity_equal() -> None:
assert Infinity == Infinity


def test_infinity_self_comparison() -> None:
assert not Infinity < Infinity
assert Infinity <= Infinity
assert not Infinity > Infinity
assert Infinity >= Infinity


def test_negative_infinity_equal() -> None:
assert NegativeInfinity == NegativeInfinity


def test_negative_infinity_self_comparison() -> None:
assert not NegativeInfinity < NegativeInfinity
assert NegativeInfinity <= NegativeInfinity
assert not NegativeInfinity > NegativeInfinity
assert NegativeInfinity >= NegativeInfinity


def test_negate_infinity() -> None:
assert isinstance(-Infinity, NegativeInfinity.__class__)

Expand Down
Loading