Fixes workspace member detection to properly handle shared path prefixes#2187
Open
edgarrmondragon wants to merge 3 commits intopypa:masterfrom
Open
Fixes workspace member detection to properly handle shared path prefixes#2187edgarrmondragon wants to merge 3 commits intopypa:masterfrom
edgarrmondragon wants to merge 3 commits intopypa:masterfrom
Conversation
Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace member resolution was mishandling cases where the main project and the member shared a partial directory name (e.g.
'path/to/local_app'and'/path/to/lib_member'share the'l'string in the last part of the path), it would return an invalid path like'/path/to/l'of the true common ancestor directory.os.path.commonpathcorrectly returns the nearest common directory, which is what we need as the base for the member glob search.This is also why
os.path.commonprefixwill be deprecated in Python 3.15: