Open
Conversation
Member
|
Sounds great! Unfortunately it's breaking crosslinking as things stand, could you investigate and fix? |
Member
|
P.S. as far as I can see, linking with yt isn't actually tested anywhere. Could you propose a way to accomplish this? I would be happy with it either as a unit (in test_yt.py) or as an integration test (in test_tutorial_build). |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few improvements to the linking operation using yt. The first improvement is to use np.searchsorted instead of np.in1d for comparing member ids of halos. The second improvement is to reduce the amount of time .member_ids is called on halo objects. The third improvement is to cache the members ids after matching ts1 to ts2, to be reused for matching ts2 to ts1.
This was done as a necessity to link catalogs for the MEGATRON suite of simulations. Linking the dark matter-only version of MEGATRON went from taking ~3 weeks to ~3 days with my improvements.