Add ep argument to compute_perievent#562
Closed
h-mayorquin wants to merge 2 commits intopynapple-org:mainfrom
Closed
Add ep argument to compute_perievent#562h-mayorquin wants to merge 2 commits intopynapple-org:mainfrom
compute_perievent#562h-mayorquin wants to merge 2 commits intopynapple-org:mainfrom
Conversation
Contributor
|
Hi Heberto, thanks for the PR. This module is currently being remade by @wulfdewolf (see #559). We are unifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close #526
Both
compute_perievent_continuousandcompute_event_trigger_averageaccept anepparameter to restrict computation to specific epochs, butcompute_perieventdid not. This inconsistency meant that passingep=somethingtocompute_perieventwas silently ignored via**kwargs(see #526).This PR adds
ep=Nonetocompute_perievent, which when provided restricts bothtimestampsandtrefto the givenIntervalSetbefore alignment. All three perievent functions now share a consistent interface for epoch filtering.