Skip to content

Comments

Neo io#503

Merged
gviejo merged 33 commits intodevfrom
neo-io
Feb 24, 2026
Merged

Neo io#503
gviejo merged 33 commits intodevfrom
neo-io

Conversation

@BalzaniEdoardo
Copy link
Collaborator

Start off a neo-io support.

@BalzaniEdoardo BalzaniEdoardo changed the base branch from main to dev October 17, 2025 16:47
@gviejo gviejo marked this pull request as ready for review February 11, 2026 20:11
@gviejo gviejo self-requested a review as a code owner February 11, 2026 20:11
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 89.82512% with 64 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pynapple/io/interface_neo.py 89.50% 32 Missing and 19 partials ⚠️
pynapple/io/interface_neurosuite.py 91.97% 8 Missing and 3 partials ⚠️
pynapple/io/misc.py 50.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
pynapple/io/__init__.py 100.00% <100.00%> (ø)
pynapple/io/misc.py 61.26% <50.00%> (-1.13%) ⬇️
pynapple/io/interface_neurosuite.py 91.97% <91.97%> (ø)
pynapple/io/interface_neo.py 89.50% <89.50%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@wulfdewolf wulfdewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

My comments are mostly for the user guide: small language comments and raising the question whether we should focus only on LFP or just saying we can load any "raw" data, which I think is better.

I managed to run it locally and it runs very smoothly, even when the data is not even downloaded locally but on some network-mounted drive.

The tests look comprehensive. I'm imagining once people start using this things might pop-up, and we might have to add tests to catch them, but I think it wouldn't be very practical trying to predict them now.

Copy link
Collaborator Author

@BalzaniEdoardo BalzaniEdoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very neat

>>> chunk = tsd[0:1000] # Loads only first 1000 samples
"""

def __init__(self, signal, block, time_support=None, sig_num=0):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this init does too much, you should probably split it in a bunch of function calls that do stuff like crating the offset array etc. In this way it will be easier to unit test these too

@h-mayorquin
Copy link

Related effort:

#563

@gviejo gviejo merged commit 2c6e6f7 into dev Feb 24, 2026
19 of 30 checks passed
@gviejo gviejo deleted the neo-io branch February 24, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants