Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
wulfdewolf
left a comment
There was a problem hiding this comment.
Looks good to me!
My comments are mostly for the user guide: small language comments and raising the question whether we should focus only on LFP or just saying we can load any "raw" data, which I think is better.
I managed to run it locally and it runs very smoothly, even when the data is not even downloaded locally but on some network-mounted drive.
The tests look comprehensive. I'm imagining once people start using this things might pop-up, and we might have to add tests to catch them, but I think it wouldn't be very practical trying to predict them now.
BalzaniEdoardo
left a comment
There was a problem hiding this comment.
Looking very neat
| >>> chunk = tsd[0:1000] # Loads only first 1000 samples | ||
| """ | ||
|
|
||
| def __init__(self, signal, block, time_support=None, sig_num=0): |
There was a problem hiding this comment.
I think this init does too much, you should probably split it in a bunch of function calls that do stuff like crating the offset array etc. In this way it will be easier to unit test these too
|
Related effort: |
Start off a neo-io support.