avoid memory overflow on corrupted file#20
Merged
insolor merged 1 commit intopymorphy2-fork:masterfrom Nov 4, 2023
Merged
Conversation
Member
|
I think I'll merge it, but actually this is a part of dawgdic code. I think we can adopt it too, but I'm not sure yet how to add it as a dependency without copy-pasting of its code. |
Member
|
@gmossessian can you please add the corresponding change here? https://github.com/pymorphy2-fork/dawgdic |
Member
|
@gmossessian if you don't mind, I'll import these changes to dawgdic |
This was referenced Nov 24, 2023
Merged
Contributor
Author
|
Thank you! Sorry I didn’t make time to do it quickly myself.
…On Fri, Nov 24, 2023 at 06:54 insolor ***@***.***> wrote:
@gmossessian <https://github.com/gmossessian> if you don't mind, I'll
import these changes to dawgdic
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVINE5VGXDHGVCD6DFE4DTYGCYL7AVCNFSM6AAAAAA64ZZDTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRVG44DGOBQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of my PR against the original abandoned DAWG project: pytries/DAWG#44
This fixes an issue that can cause the dawg to allocate a lot of memory on load in the case of a corrupted file.
Unfortunately, the original dawgdic library looks like it has long since ceased to be maintained, so I am opening a PR against the python wrapper.
To replicate the issue, use the following script:
If you run this under
gtimeon OSX, you will see somewhere between 4 and 6GB of RAM being used.After this PR, this number is greatly reduced