feat: make OMEStream.view() public; allow opening after stream.close#111
Merged
tlambert03 merged 11 commits intomainfrom Feb 26, 2026
Merged
feat: make OMEStream.view() public; allow opening after stream.close#111tlambert03 merged 11 commits intomainfrom
OMEStream.view() public; allow opening after stream.close#111tlambert03 merged 11 commits intomainfrom
Conversation
Merging this PR will degrade performance by 51.83%
Performance Changes
Comparing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 97.37% 97.46% +0.08%
==========================================
Files 21 21
Lines 2250 2285 +35
==========================================
+ Hits 2191 2227 +36
+ Misses 59 58 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… and error checks
…equirement in error message
OMEStream.view() public. allow opening after stream.closeOMEStream.view() public; allow opening after stream.close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this exposes what had been a private feature: the arraylike view onto an ongoing stream. This provides a write-backend-abstracted view onto an ongoing (and now also closed) stream. Intended for use by gui/viewers
the main api now is: