Skip to content

feat: make OMEStream.view() public; allow opening after stream.close#111

Merged
tlambert03 merged 11 commits intomainfrom
public-view
Feb 26, 2026
Merged

feat: make OMEStream.view() public; allow opening after stream.close#111
tlambert03 merged 11 commits intomainfrom
public-view

Conversation

@tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Feb 25, 2026

this exposes what had been a private feature: the arraylike view onto an ongoing stream. This provides a write-backend-abstracted view onto an ongoing (and now also closed) stream. Intended for use by gui/viewers

the main api now is:

with create_stream(...) as stream:
    view = stream.view()

@tlambert03 tlambert03 marked this pull request as ready for review February 25, 2026 21:24
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 25, 2026

Merging this PR will degrade performance by 51.83%

❌ 1 (👁 1) regressed benchmark
✅ 18 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
👁 test_bench_append[t5_c2_z3_xy256-tensorstore] 51.3 ms 106.4 ms -51.83%

Comparing public-view (18f6165) with main (1ac01ed)

Open in CodSpeed

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 98.48485% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.46%. Comparing base (1ac01ed) to head (18f6165).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ome_writers/_backends/_yaozarrs.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   97.37%   97.46%   +0.08%     
==========================================
  Files          21       21              
  Lines        2250     2285      +35     
==========================================
+ Hits         2191     2227      +36     
+ Misses         59       58       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 changed the title feat: make OMEStream.view() public. allow opening after stream.close feat: make OMEStream.view() public; allow opening after stream.close Feb 26, 2026
@tlambert03 tlambert03 merged commit 5cc4747 into main Feb 26, 2026
230 checks passed
@tlambert03 tlambert03 deleted the public-view branch February 26, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant