feat: allow passing AqcuisitionSettings kwargs directly to create_stream#109
Draft
tlambert03 wants to merge 7 commits intopymmcore-plus:mainfrom
Draft
feat: allow passing AqcuisitionSettings kwargs directly to create_stream#109tlambert03 wants to merge 7 commits intopymmcore-plus:mainfrom
tlambert03 wants to merge 7 commits intopymmcore-plus:mainfrom
Conversation
Merging this PR will degrade performance by 30.25%
Performance Changes
Comparing Footnotes |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 97.73% 97.65% -0.08%
==========================================
Files 21 21
Lines 2472 2477 +5
==========================================
+ Hits 2416 2419 +3
- Misses 56 58 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
really not sure about this one, so will just put here and let it sit
This PR allows this syntax:
as a shorthand for creating settings first, then passing them in: