Skip to content

Add JSON-RPC notifications#127

Merged
BenediktBurger merged 3 commits intomainfrom
add-json-notifications
Jun 12, 2025
Merged

Add JSON-RPC notifications#127
BenediktBurger merged 3 commits intomainfrom
add-json-notifications

Conversation

@BenediktBurger
Copy link
Member

@BenediktBurger BenediktBurger commented May 27, 2025

According to JSON-RPC specs, a server MUST NOT respond to a notification (a message without an id).

Supports development of #91 due to notifications

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (25ae333) to head (a73be50).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   91.04%   91.09%   +0.04%     
==========================================
  Files          36       36              
  Lines        2905     2919      +14     
  Branches      293      298       +5     
==========================================
+ Hits         2645     2659      +14     
  Misses        224      224              
  Partials       36       36              
Flag Coverage Δ
unittests 91.09% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BenediktBurger BenediktBurger force-pushed the add-json-notifications branch 2 times, most recently from c62b097 to 40a51d1 Compare May 27, 2025 14:58
@BenediktBurger BenediktBurger changed the title Add json notifications Add JSON-RPC notifications May 27, 2025
@BenediktBurger BenediktBurger force-pushed the add-json-notifications branch 4 times, most recently from b38f5d1 to ab746fe Compare June 12, 2025 05:53
@BenediktBurger BenediktBurger force-pushed the add-json-notifications branch from ab746fe to a73be50 Compare June 12, 2025 06:00
@BenediktBurger BenediktBurger merged commit a879797 into main Jun 12, 2025
39 of 42 checks passed
@BenediktBurger BenediktBurger deleted the add-json-notifications branch June 12, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant