Update code to ensure tests pass correctly in more modern verisons of python#134
Open
MoralCode wants to merge 11 commits intopylover:masterfrom
Open
Update code to ensure tests pass correctly in more modern verisons of python#134MoralCode wants to merge 11 commits intopylover:masterfrom
MoralCode wants to merge 11 commits intopylover:masterfrom
Conversation
append couldnt be used because self.thumbnails was read only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the unit tests in the cleanest way possible with minimal changes to existing functionality.
Changes include:
Imageobject, causing test failures (fixes unit tests failing in newer python versions (3.8) because self.thumbnails cannot be appended to #133)GoogleCloudStorageclass to allow the test to properly loadstuff/cat.jpgimage inGoogleCloudStoragetests so the tests actually run