added support for IAM role authentication#132
Open
dylanjsa wants to merge 1 commit intopylover:masterfrom
Open
added support for IAM role authentication#132dylanjsa wants to merge 1 commit intopylover:masterfrom
dylanjsa wants to merge 1 commit intopylover:masterfrom
Conversation
MoralCode
reviewed
Dec 11, 2022
MoralCode
left a comment
MoralCode
left a comment
There was a problem hiding this comment.
Despite being someone who hasnt ever really used S3, this looks good to me overall!
Could you maybe add some unit test cases that demonstrate the functionality of this new auth mechanism (the GoogleCloudStorage class uses mocks to fake the google backend, that may be a useful starting point, i just added some fixups to these tests on my fork of the repo)
|
To me it looks like the current s3 tests covers this usage already. On AWS, if deployed on AWS infrastructure, boto will automatically be authed according to an IAM role assigned to the infrastructure(EC2/lambda), if the auth details are not specified. This PR merely allows you to not specify auth details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this functionality would be useful when applications are deployed with cloudformation stacks.
we can deploy an IAM role with access to the specified s3 bucket alongside the application without needing to worry about creating a User with access keys.
Amazon recommends that User accounts are created for physical real people and not for robots.