Open
Conversation
pylover
requested changes
Aug 23, 2021
Owner
pylover
left a comment
pylover
left a comment
There was a problem hiding this comment.
Max,
Thanks a lot.
The S3 store mainly developed by @YukSeungChan, I'll ask him to review this PR.
But don't worry if Yuk was busy I'll check it.
Please keep the code coverage rate greater than what it was.
I'll add some commits into master to migrate from travis to gh-actinos.
Again, thanks for the contribution.
Owner
|
Max, Could you please describe the problem this PR going to fix it?: |
Author
As httpx have sync and async APIs, it will be much easier to add async API to the library and keep sync API as well. |
pylover
requested changes
Aug 24, 2021
…my session factory
TheLazzziest
force-pushed
the
feature/httpx
branch
from
93a1d54 to
5b125db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I want to add async APIs to the library. The first step is to move to httpx which is resembled in this PR. Also, I want to make sure, the changes are good from conceptual and practical perspectives. If we are good at this step, the next PR will contain the changes related to API itself.
BTW, I have also made some changes to requests-aws4auth#55 to add httpx support.