Skip to content

Conversation

@Dru94
Copy link

@Dru94 Dru94 commented Jan 17, 2019

Login and registration feature

Copy link

@edison12a edison12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

@edison12a
Copy link

Please specify in the readme.MD how another developer can run your project

@edison12a
Copy link

And.. How can I test the feature that you added?

@edison12a
Copy link

@lubegamark, Please review

@edison12a
Copy link

@phillipahereza

@phillipahereza phillipahereza changed the base branch from master to develop June 30, 2019 12:22
@phillipahereza
Copy link
Contributor

@Dru94 Very Good work so far. I changed the base branch to develop, so that causes a few conflicts but they shouldn't be hard to fix. Also could you remove the .pyc files, they're already added to .gitignore.

@@ -0,0 +1,3 @@
from django.test import TestCase

# Create your tests here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dru94 could you add a few tests

from django.contrib.auth.views import LoginView,LogoutView, PasswordResetView, PasswordResetDoneView, \
PasswordResetConfirmView, PasswordResetCompleteView

urlpatterns=[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dru94 what do you think about using social login instead, I'm thinking maybe GitHub and Google. I suggest you use Django Allauth but you can suggest any other package that does the same thing

return render(request, 'base.html')

#registration view
def reg(request):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dru94 use proper function names, reg should be register, I know there's a comment that says registration view but code should be self documenting and require very little comments

@phillipahereza phillipahereza changed the title Andrew Musali [Feature] User Creation and Login Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants