Skip to content

Conversation

@h-chmeruk
Copy link
Contributor

Which issue(s) are closed by this pull request?

Closes #15

Changes proposed in this pull request:

  • Added new fixture default_project to prevent a new project from being created for each new test.
  • Adjusted existing test functions so that default_project is used as a parameter instead of creating new projects.
  • The functions test_content_license() and test_license_choice_other() remained unchanged since they require extra_answers other than those contained in default_project.

@h-chmeruk h-chmeruk added the enhancement New feature or request label Jan 6, 2026
@h-chmeruk h-chmeruk requested a review from ahms5 January 9, 2026 08:53
Copy link
Member

@ahms5 ahms5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small thing, otherwise approved. really nice feature. Thanks

Comment on lines 3 to 7
@pytest.fixture(scope="session")
def default_project(copie_session, copier_project_defaults):
project = copie_session.copy(
extra_answers=copier_project_defaults)
return project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this into conftest.py

@ahms5 ahms5 mentioned this pull request Jan 9, 2026
@ahms5 ahms5 added this to the v0.1.0 milestone Jan 9, 2026
@ahms5 ahms5 added documentation Improvements or additions to documentation enhancement New feature or request and removed enhancement New feature or request documentation Improvements or additions to documentation labels Jan 9, 2026
@h-chmeruk h-chmeruk requested a review from ahms5 January 9, 2026 09:54
@h-chmeruk h-chmeruk merged commit 815c030 into main Jan 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessarily time-consuming tests of content

3 participants