[ENH] Initialize spherical harmonics from definition #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-brinkmann
force-pushed
the
feature/sh_instance_from_definition
branch
from
73cb668 to
eaa6f78
Compare
f-brinkmann
requested review from
a team,
ahms5,
hoyer-a,
mberz,
sikersten and
tluebeck
mberz
requested changes
Dec 16, 2025
Member
mberz
left a comment
mberz
left a comment
There was a problem hiding this comment.
I'd suggest to change the order of arguments (for semantic and consistency reasons), see below)
Otherwise good to go
spharpy/classes/sh.py
Outdated
| self.inverse_method = inverse_method | ||
|
|
||
| @classmethod | ||
| def from_definition(cls, coordinates, definition, inverse_method="auto"): |
Member
There was a problem hiding this comment.
Suggested change
| def from_definition(cls, coordinates, definition, inverse_method="auto"): | |
| def from_definition(cls, definition, coordinates, inverse_method="auto"): |
I'd suggest to change the order to keep things consistent when thinking about other cases (like audio classes etc., they all will require the definition + other things)
Member
Author
|
I was discussing the same with @mberz yesterday and we thought having shorter names in both cases would be fine ( if I remember correctly). Specifically in this case |
mberz
changed the title
mberz
approved these changes
Dec 17, 2025
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
Member
|
I additionally fixed a conflict with the current develop branch. |
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Weekly Planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
SphericalHarmonics.from_definitionNote: Allready uses docstring suggested in #246, which will be implemented through the same pull request also here.
Requires #246