-
Notifications
You must be signed in to change notification settings - Fork 3
Plots/Create baseline plots #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactor/collect_cb_changes
Are you sure you want to change the base?
Conversation
f-brinkmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are lots of plots where color indicated amplitude before and now indicates phase. Is that desired?
|
The default behavior changed when we replaced phase=False/True with cmap_encoding=phase/magnitude, but apparently many baseline figures were never updated. We briefly spoke about this in the last weekly. Related pull #184 |
|
Thanks for taking care! Some of the baseline plots have not changed. Should we only include those that changed to keep a clean history? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just using this as an example, the same applies for some of the plots below:
The colorbar obstructs the tick and axis labels. Wasn't this improved as part of #220?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed solution was to return axes and colorbar and allow lists of axes, so the plot / colorbar layout can be adjusted individually
#211 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there is a simple fix for this, like increasing the figure size? If yes, this would be fine for me. If not it might be worth improving the default behaviour - but probably in a separate pull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment to the original issue on this #183
Maybe let's explore this first before finalizing the new baseline plots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I will look into this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should fix this in an other PR, because this PR is just to update the baseline, in case were we forgot it. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anton and I found that this remains a Matplotlib problem for which there is no universal default solution. As discussed in the weekly, people will have to specify their own axis in some cases to avoid overlaps. Anton will suggest a docstring for the plot-module which explains this and gives an example on how avoid it using grid specs
42df3ff to
1d58eed
Compare
8311b1e to
cd4c63a
Compare
1d58eed to
bfd5d5c
Compare
|
Does this already include #257? |
|
Now the baseline plots include #257. Unfortunately the colorbar-placement did not improve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anton and I found that this remains a Matplotlib problem for which there is no universal default solution. As discussed in the weekly, people will have to specify their own axis in some cases to avoid overlaps. Anton will suggest a docstring for the plot-module which explains this and gives an example on how avoid it using grid specs
Note
Merges into #222
Changes proposed in this pull request:
pcolor_sphere,balloonandballoon_wireframehas changed from'magnitude'to'phase'