Skip to content

Conversation

@hoyer-a
Copy link
Member

@hoyer-a hoyer-a commented Jan 6, 2026

Which issue(s) are closed by this pull request?

Closes #110

Changes proposed in this pull request:

  • flatten signals before edc-calculations
  • reshape edc to original shape at the end
  • allow multi-dimensional input signals as for example from fractional octave filters (n_bands, *cdim, n_samples)

Question

I considered this a bugfix and branched off from main, is this correct?

@hoyer-a hoyer-a added the enhancement New feature or request label Jan 6, 2026
@hoyer-a hoyer-a added the bug Something isn't working label Jan 6, 2026
@hoyer-a hoyer-a moved this from Backlog to Require review in Weekly Planning Jan 6, 2026
@hoyer-a hoyer-a added this to the v0.4.2 milestone Jan 6, 2026
Copy link
Member

@f-brinkmann f-brinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care. I would suggest to make the tests a little more strict.

Comment on lines +118 to +119
npt.assert_array_equal(
np.isfinite(edc.time[..., :int(rir.sampling_rate*0.4)]), True)
Copy link
Member

@f-brinkmann f-brinkmann Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be more strict to compare against the EDC computed using a single channel signal. For example (did not check if the code works...)

Suggested change
npt.assert_array_equal(
np.isfinite(edc.time[..., :int(rir.sampling_rate*0.4)]), True)
for idx in np.ndindex(rir_oct.cshape)
reference = edc_function(rir_oct[idx])
npt.assert_equal(baseline.time, edc[idx].time)

@hoyer-a hoyer-a moved this from Require review to Drafting Phase in Weekly Planning Jan 6, 2026
@hoyer-a hoyer-a marked this pull request as draft January 6, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

Status: Drafting Phase

Development

Successfully merging this pull request may close these issues.

[BUG] EDC-Functions can't handle Signals with cdim > 1

3 participants